Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion

a discussion (no related file):
Something is not working yet (unusable report): https://app.codecov.io/github/pmem/rpma/commit/3e89b0b4957d9831ced07684f04a2191b7f6a241

Reviewable status: 0 of 5 files reviewed, 4 unresolved discussions (waiting on @ldorau)

.github/workflows/coverage.yml line 30 at r1 (raw file):

    steps:
       - name: Clone the git repo
         uses: actions/checkout@v1

I believe there's v3 already

.github/workflows/coverage.yml line 40 at r1 (raw file):

       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3
         with:

you can enable verbose log: verbose: true

utils/docker/build.sh line 74 at r1 (raw file):

docker run --privileged=true --name=$containerName -i $TTY \
	$DNS_SETTING \
	${docker_opts} \

redundant now, I believe

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ldorau and @lukaszstolarczuk)

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @lukaszstolarczuk)

.github/workflows/coverage.yml line 30 at r1 (raw file):

Done.

Code quote:

uses: actions/checkout@v1

.github/workflows/coverage.yml line 40 at r1 (raw file):

Done

utils/docker/build.sh line 74 at r1 (raw file):

Right.

Code quote:

${docker_opts}

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukaszstolarczuk)

Reviewable status: 4 of 5 files reviewed, 7 unresolved discussions (waiting on @grom72, @ldorau, and @lukaszstolarczuk)

.github/workflows/coverage.yml line 33 at r3 (raw file):

       - name: Pull or rebuild the image
         run: cd $WORKDIR && ${{ matrix.CONFIG }} ./pull-or-rebuild-image.sh

You may need to use the following definition for ${{ matrix.CONFIG }}:

      matrix:
        CONFIG: ["N=1 OS=ubuntu OS_VER=latest TYPE=normal CC=gcc" TESTS_COVERAGE=1]

or remove ${{ matrix.CONFIG }} directly.

.github/workflows/coverage.yml line 36 at r3 (raw file):

       - name: Run the build
         run: cd $WORKDIR && ${{ matrix.CONFIG }} ./build.sh

The same comment.

.github/workflows/coverage.yml line 39 at r3 (raw file):

       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3

Is download-scripts.sh still necessary if we plan to use download-scripts.sh?

Reviewable status: 4 of 5 files reviewed, 7 unresolved discussions (waiting on @grom72, @lukaszstolarczuk, and @yangx-jy)

.github/workflows/coverage.yml line 33 at r3 (raw file):

It's just a missed leftover. I removed the build matrix on purpose and just forgot to remove it.

Removed.

.github/workflows/coverage.yml line 36 at r3 (raw file):

Done.

.github/workflows/coverage.yml line 39 at r3 (raw file):

Right, they will not be needed. Removed.

Reviewed 2 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @yangx-jy)

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

The last result (still "unusable report"): https://app.codecov.io/github/pmem/rpma/commit/ac0240e7d421d64310f4d0106f30432e886c5e59

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @lukaszstolarczuk)

a discussion (no related file):

Let's see: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223

Reviewed 1 of 1 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

a discussion (no related file):

Waiting for help from the support team: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223 ...

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau and @lukaszstolarczuk)

a discussion (no related file):

@ldorau, does it work now as expected?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @lukaszstolarczuk)

a discussion (no related file):

No, it still does not work

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

a discussion (no related file):

The codecov/codecov-action@v3 action still does not work as expected:
https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223/17

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

a discussion (no related file):

v1.3.0 released: https://github.com/pmem/rpma/releases/tag/1.3.0

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72, @lukaszstolarczuk, and @yangx-jy)

a discussion (no related file):

You are welcome :-)